i18n: Absorb errors from Jed localization #5481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5459
This pull request seeks to update localization functions to wrap Jed localization functions, as they throw errors on invalid input, which as can be seen in #5459 causes the entire application to crash. The wrapper absorbs the error, logging it to the console, and returning a sensible default (the untranslated singular string or format).
Testing instructions:
Verify that there are no regressions in the display of localized strings.
Extra credit: Verify that, with an invalid string (e.g. missing placeholder value), no crash occurs and the sensible default is shown.