Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REACT error: [sprintf] property "selectedCount" does not exist #5459

Closed
2 tasks
pfefferle opened this issue Mar 7, 2018 · 12 comments
Closed
2 tasks

REACT error: [sprintf] property "selectedCount" does not exist #5459

pfefferle opened this issue Mar 7, 2018 · 12 comments
Assignees
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Comments

@pfefferle
Copy link
Member

pfefferle commented Mar 7, 2018

Issue Overview

If I hover over the editor I get the error:

bildschirmfoto 2018-03-07 um 10 24 05

bildschirmfoto 2018-03-07 um 10 25 06

Steps to Reproduce (for bugs)

  1. Install Gutenberg 2.3.0
  2. Go to Demo-page
  3. Hover over text in editor

My system:

  • WordPress 4.9.4 (german)
  • MacBook Pro/macOS 10.13.3
  • Safari Version 11.0.3
  • Chrome Version 64.0.3282.186

Expected Behavior

Current Behavior

Possible Solution

Screenshots / Video

Related Issues and/or PRs

Todos

  • Tests
  • Documentation
@aduth
Copy link
Member

aduth commented Mar 7, 2018

I'm unable to reproduce this. Can you clarify whether you have any other plugins activated on the site?

And over what specifically you are hovering when this error occurs?

@pfefferle
Copy link
Member Author

I tested it in a blank docker container with a standard WordPress installation.

It shows up, if I hover over a block:

marz-07-2018 15-36-00

@pfefferle
Copy link
Member Author

I could even reproduce it in a virtual box with Windows and Edge

@pfefferle
Copy link
Member Author

Duplicate #5472

It seems to be a problem with the German translation!

@aduth
Copy link
Member

aduth commented Mar 7, 2018

The issue can be seen here:

https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/de/default?filters%5Bterm%5D=selectedCount&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

image

Note that the second translated string includes a placeholder value which does not exist in the original string.

cc @Presskopp

@aduth
Copy link
Member

aduth commented Mar 7, 2018

That being said, a failure to translate a string should ideally not crash the entire application.

@Presskopp
Copy link
Contributor

Uh, sorry, translation corrected

@aduth aduth self-assigned this Mar 7, 2018
@aduth aduth added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts labels Mar 7, 2018
@pfefferle
Copy link
Member Author

Is it possible to trigger the language update, for a quick fix?

@chameleon-tbn
Copy link

For german language you can go to https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/de/default and select at the bottom Export - all current - po and afterwards export the mo. Rename the downloaded files to gutenberg-de_DE.po and gutenberg-de_DE.mo and upload them via ftp to wp-content/languages/plugins

At least I can use Gutenberg again...

@Presskopp
Copy link
Contributor

You can use the files inside this zip and save them to wp-content/languages/plugins

language-files.zip

@Presskopp
Copy link
Contributor

duplicate here: #5529

@ThomasKujawa
Copy link

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants