Migrate PostTypeSupportCheck usages from withSelect to hooks #53330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
Size Change: -19 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
jsnajdr
changed the title
tyxla
approved these changes
Aug 4, 2023
| } | ||
| }; | ||
| const value = orderInput === null ? order : orderInput; | ||
|
|
||
| const value = orderInput ?? order; |
Comment on lines
+17
to
+24
| const { lastRevisionId, revisionsCount } = useSelect( ( select ) => { | ||
| const { getCurrentPostLastRevisionId, getCurrentPostRevisionsCount } = | ||
| select( editorStore ); | ||
| return { | ||
| lastRevisionId: getCurrentPostLastRevisionId(), | ||
| revisionsCount: getCurrentPostRevisionsCount(), | ||
| }; | ||
| }, [] ); |
There was a problem hiding this comment.
This is duplicated between this component and the underlying PostLastRevisionCheck component, could be a good opportunity to extract to a hook.
There was a problem hiding this comment.
That's true, and I think there are multiple opportunities like this. There's also the PageAttributesCheck component, which duplicates code from the generic PostTypeSupportCheck. It could easily be converted into a simple <PostTypeSupportCheck supportsKeys="page-attributes'> instance.
But I didn't want to make too many diverse changes at once in this PR.
There was a problem hiding this comment.
Agreed on not making this PR too large. Definitely material for a follow-up if you want to pursuit it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @Mamaduka's #53235, this PR removes a few more usages of
withSelectfrom components that usePostTypeSupportCheck.withSelectusages are converted touseSelecthooks, updating also some unit tests that now needuseSelectmockingPostTypeSupportCheck. It accepts onlychildren(in addition tosupportKey), so we always usechildrenexplicitly instead of generic...propspassthroughs.