Editor: Use hooks instead of HoCs in PostTypeSupportCheck
#53235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
Mamaduka,
aristath,
jsnajdr,
flootr,
chad1008,
ntsekouras and
brookewp
|
Size Change: -40 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fa8046f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5728422964
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates
PostTypeSupportCheckto use theuseSelecthook rather than thewithSelectHoC.Why?
A micro-optimization to makes the rendered component tree smaller. With the change we render one less wrapper component. Due to the usage of this component, for the post editor screen, this can add up to 9-10 times for the default core setup, rendering 9-10 fewer wrapper components.
Discovered while working on #53232, #53231, #53229, and #53228.
How?
We're using the
useSelecthook instead of thewithSelectHoC.Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None