Spacing presets: fix bug with select control adding undefined preset values #53005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrol in getPresetValueFromCustomValueControl
glendaviesnz
added
[Type] Bug
|
@andrewserong just pinging you to double-check that I haven't overlooked any use cases in modifying this function that was introduced in #43466? |
|
Size Change: +23 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Nope! I think it should just return the value as-is if it's falsy, same as what we're doing with |
Thanks for verifying, I merged all of those checks into one, didn't make sense to keep the undefined one separate. |
andrewserong
added
the
Backport to WP 6.7 Beta/RC
andrewserong
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Thanks Glen, LGTM, this is testing nicely! ✨
I've just added the backport label as this is fairly similar to a related fix that made it in for 6.3 (#52711), so it'd be good to see if we can get this fix in too, if it isn't too late.
glendaviesnz
added
[Type] Enhancement
ramonjd
pushed a commit
that referenced
this pull request
Jul 28, 2023
|
I just cherry-picked this PR to the update/packages-wp-6-3-RC3 branch to get it included in the next release: 022f9dc |
ramonjd
removed
the
Backport to WP 6.7 Beta/RC
ramonjd
added a commit
that referenced
this pull request
Jul 28, 2023
* Patterns: Enable focus mode editing (#52427) * PreventDefault when isComposing is true. apply patch from t-hamano. (#52844) see: #52821 (comment) * List View: Ensure onDrop does not fire if there is no target (#52959) * I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar (#52971) * I18N: Add missing gettext wrapper * Add context to disambiguate 'Outline' that is commonly used on borders. * Footnotes: disable based on post type (#52934) * Footnotes: disable based on post type * Address feedback * Fix typo * Format: disable if block is not registered * Lock usesContext api * Use Symbol instead of Math.random * Patterns Browse Screen: Fix back button when switching between categories (#52964) * Patterns: Allow orphaned template parts to appear in general category (#52961) * Spacing presets: fix bug with select control adding undefined preset values (#53005) * Site Editor: Fix canvas mode sync with URL (#52996) * Check if spacing tool is defined before displaying controls. (#53008) * Check if spacing tool is defined before displaying controls. * Don't show sides if spacing type false * Improve consistency of the Post editor and Site editor Document actions (#52246) * Remove redundant shortcut button. * Fix focus and hover style and improve consistency. * Rename post document-title and improve CSS consistency. * Site Editor: Fix the typo in the title label map (#53071) * Fix patterns search crash: check for existence of defaultView before attempting to get styles (#52956) * backport paging bug fixes (#53091) --------- Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Hiroshi Urabe <[email protected]> Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: Pedro Mendonça <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: tellthemachines <[email protected]> Co-authored-by: Andrea Fercia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug where the select list used if more than 7 preset values adds invalid preset value attributes.
Why?
Fixes: #52976
How?
Accounts for the undefined value set by spacing presets select list control in getPresetValueFromCustomValueControl.
Testing Instructions
settings.spacing.spacingPresetsvalues to 8+Defaultoption in the select listvar:preset|spacing|defaultScreenshots or screencast
Before:
spacing-presets-default.mp4
After:
spacingpresets-after.mp4