-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommandPalette: Fixed to not execute commands in IME composition. #52844
Conversation
Size Change: +34 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
@mirka we need a Mac and an IME to test this issue. Can you test it for me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me, and we've already discussed and implemented this approach in some wp-components as well 👍
Reproduced and confirmed fixed on Mac Safari and Mac Chrome. (Doesn't repro in Mac Firefox, as noted in the original issue.)
I think this PR will solve an important problem in languages that use IMEs, so I will give it a backport label. |
I just cherry-picked this PR to the update/packages-wp-6-3-RC3 branch to get it included in the next release: 8142681 |
* Patterns: Enable focus mode editing (#52427) * PreventDefault when isComposing is true. apply patch from t-hamano. (#52844) see: #52821 (comment) * List View: Ensure onDrop does not fire if there is no target (#52959) * I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar (#52971) * I18N: Add missing gettext wrapper * Add context to disambiguate 'Outline' that is commonly used on borders. * Footnotes: disable based on post type (#52934) * Footnotes: disable based on post type * Address feedback * Fix typo * Format: disable if block is not registered * Lock usesContext api * Use Symbol instead of Math.random * Patterns Browse Screen: Fix back button when switching between categories (#52964) * Patterns: Allow orphaned template parts to appear in general category (#52961) * Spacing presets: fix bug with select control adding undefined preset values (#53005) * Site Editor: Fix canvas mode sync with URL (#52996) * Check if spacing tool is defined before displaying controls. (#53008) * Check if spacing tool is defined before displaying controls. * Don't show sides if spacing type false * Improve consistency of the Post editor and Site editor Document actions (#52246) * Remove redundant shortcut button. * Fix focus and hover style and improve consistency. * Rename post document-title and improve CSS consistency. * Site Editor: Fix the typo in the title label map (#53071) * Fix patterns search crash: check for existence of defaultView before attempting to get styles (#52956) * backport paging bug fixes (#53091) --------- Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Hiroshi Urabe <[email protected]> Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: Pedro Mendonça <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: tellthemachines <[email protected]> Co-authored-by: Andrea Fercia <[email protected]>
What?
Similar to 45607, if
isComposing
istrue
when Enter is pressed, the event was prevented.Apply patch from @t-hamano
#52821 (comment)
Why?
fix: #52821
How?
Use cmdk props.onKeydown to execute event.preventDefault() when Enter is pressed. cmdk will not execute anything on keyDown if event.defaultPrevented is true.
https://github.com/pacocoursey/cmdk/blob/ba2e20035ad86a2cb0fae0c2c296796e48a0181c/cmdk/src/index.tsx#L515
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast