Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Color Selection Option for FootNote Block #52918

Conversation

ghorivipul97
Copy link
Contributor

What?

Added Color Selection Option for FootNote Block

Why?

#51991

How?

Allow Color Selection for block

image

@richtabor
Copy link
Member

Should also add support for link color as well; so that the footnote link can be colorized.

CleanShot 2023-07-25 at 13 03 49

@richtabor
Copy link
Member

Actually, I just saw this PR (#52897) was merged an hour ago with this feature already implemented. Thanks for the PR but I'll close in lieu of that.

You could explore other dimensions controls perhaps; like padding and margin (off by default).

@richtabor richtabor closed this Jul 25, 2023
@ndiego
Copy link
Member

ndiego commented Jul 25, 2023

Thanks for working on this @ghorivipul97, but this PR can be closed. @mikachan already tackled this here: #52897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants