-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footnote: changing link color doesn't update footnote arrow link color #51991
Comments
Hm, so you expect the link colour of the anchor to also change the back link colour? Not sure how this all works. Do you know who created this feature? |
I do expect that or at least a way to change the color of the arrow/back link. As for the "feature", do you mean color options? |
@annezazu I'm here, can you able to assign me |
I think the link color change should only apply to the links in that block (i.e. Paragraph Block) and should not affect other blocks (i.e. Footnotes block). If the Footnote block itself supported link colors, this problem would be solved. |
okay @t-hamano |
Agreed. I think the next step here is to add color (and additional block supports) to the Footnotes block. @ghorivipul97 is this something you are actively working on? If not, can you unassign yourself? |
I've opened a quick PR for updating the block supports, #52897, as I think this is all we need to address this issue. Happy to work with anything @ghorivipul97 has in progress, too! |
Hello @mikachan |
Description
Using 16.1 RC 2 and testing footnotes, I noticed that after setting a link color, that color is only respected in the text itself but not in the arrow to return next to the footnote itself to return. I expect to be able to have the colors match, especially since the current color offered isn't accessibility ready. cc @ellatrix for more insight as I wonder if this has to be set elsewhere.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
footnote.color.mov
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: