Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote: changing link color doesn't update footnote arrow link color #51991

Closed
annezazu opened this issue Jun 27, 2023 · 8 comments · Fixed by #52897
Closed

Footnote: changing link color doesn't update footnote arrow link color #51991

annezazu opened this issue Jun 27, 2023 · 8 comments · Fixed by #52897
Assignees
Labels
[Block] Footnotes Affects the Footnotes Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

Using 16.1 RC 2 and testing footnotes, I noticed that after setting a link color, that color is only respected in the text itself but not in the arrow to return next to the footnote itself to return. I expect to be able to have the colors match, especially since the current color offered isn't accessibility ready. cc @ellatrix for more insight as I wonder if this has to be set elsewhere.

Step-by-step reproduction instructions

  1. Open the Post Editor.
  2. Add some text.
  3. Highlight some text, use the drop down menu in the block toolbar to add a footnote.
  4. Open block settings and set a link color.
  5. Notice this updates the (1) color but not the arrow of the footnote itself.

Screenshots, screen recording, code snippet

footnote.color.mov

Environment info

  • WP 6.2.2
  • GB 16.1 RC 2
  • TT3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Footnotes Affects the Footnotes Block labels Jun 27, 2023
@ellatrix
Copy link
Member

Hm, so you expect the link colour of the anchor to also change the back link colour? Not sure how this all works. Do you know who created this feature?

@annezazu
Copy link
Contributor Author

annezazu commented Jul 3, 2023

I do expect that or at least a way to change the color of the arrow/back link. As for the "feature", do you mean color options?

@ghorivipul97
Copy link
Contributor

@annezazu I'm here, can you able to assign me

@t-hamano
Copy link
Contributor

t-hamano commented Jul 7, 2023

I think the link color change should only apply to the links in that block (i.e. Paragraph Block) and should not affect other blocks (i.e. Footnotes block). If the Footnote block itself supported link colors, this problem would be solved.

@ghorivipul97
Copy link
Contributor

okay @t-hamano
I will do it

@ellatrix ellatrix added [Type] Feature New feature to highlight in changelogs. [Type] Enhancement A suggestion for improvement. and removed [Type] Feature New feature to highlight in changelogs. labels Jul 17, 2023
@ndiego
Copy link
Member

ndiego commented Jul 24, 2023

I think the link color change should only apply to the links in that block (i.e. Paragraph Block) and should not affect other blocks (i.e. Footnotes block). If the Footnote block itself supported link colors, this problem would be solved.

Agreed. I think the next step here is to add color (and additional block supports) to the Footnotes block.

@ghorivipul97 is this something you are actively working on? If not, can you unassign yourself?

@mikachan
Copy link
Member

I've opened a quick PR for updating the block supports, #52897, as I think this is all we need to address this issue.

Happy to work with anything @ghorivipul97 has in progress, too!

@mikachan mikachan moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.3.x Editor Tasks Jul 24, 2023
@mikachan mikachan moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.3.x Editor Tasks Jul 24, 2023
@ndiego ndiego moved this from 🔎 Needs Review to 🦵 Punted to 6.4 in WordPress 6.3.x Editor Tasks Jul 24, 2023
@ghorivipul97
Copy link
Contributor

Hello @mikachan
it's done and raise PR.

@github-project-automation github-project-automation bot moved this from 🦵 Punted to 6.4 to ✅ Done in WordPress 6.3.x Editor Tasks Jul 25, 2023
@bph bph removed the [Type] Enhancement A suggestion for improvement. label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Footnotes Affects the Footnotes Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants