Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #52886 Make all the 'Loading' strings consistent #52901

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

ducksblock
Copy link
Contributor

What?

Making all the 'Loading' strings consistent

Why?

Making the Loading strings consistent adds to the UI. Here I am fixing #52886 issue which will improve the overall user experience.

How?

I have changed the strings that were not consistent. I have added an ellipsis at the end of every 'Loading' string.

Testing Instructions

  1. Open any page where loading pops up
  2. Observe the 'Loading' strings

Testing Instructions for Keyboard

N/A.

Screenshots or screencast

N/A

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 24, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ducksblock! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka requested a review from afercia July 25, 2023 11:32
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ducksblock !
Apologies, maybe I was not clear.
I'm not sure changing all the strings to just Loading… would be ideal. I'd keep the additional text because it adds some useful context. I'd suggest to just add the ellipsis and fix the typos.

@ducksblock
Copy link
Contributor Author

@afercia I have updated the files as per the request.

Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM to me, tests pass, all green.

@ducksblock
Copy link
Contributor Author

@geriux @tellthemachines It'd be great if you guys could review this :)

@geriux
Copy link
Member

geriux commented Aug 4, 2023

@geriux @tellthemachines It'd be great if you guys could review this :)

Hey there! These changes don't affect the mobile editor but in any case, it looks good to me 👍

@ducksblock
Copy link
Contributor Author

@geriux @tellthemachines It'd be great if you guys could review this :)

Hey there! These changes don't affect the mobile editor but in any case, it looks good to me 👍

Thanks! Can you please approve it so that it can get merged?

@t-hamano t-hamano self-requested a review August 13, 2023 16:24
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ducksblock Thank you for your contribution!

The code looks good to me, no conflicts, and all tests pass, so I would like to merge it.

@t-hamano t-hamano merged commit b81557b into WordPress:trunk Aug 13, 2023
@github-actions
Copy link

Congratulations on your first merged pull request, @ducksblock! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 13, 2023
@t-hamano t-hamano added the [Type] Copy Issues or PRs that need copy editing assistance label Aug 13, 2023
@SiobhyB SiobhyB added the [Feature] Navigation Menus Any issue relating to Navigation Menus label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Navigation Menus Any issue relating to Navigation Menus First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants