Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all the 'Loading' strings consistent #52886

Closed
afercia opened this issue Jul 24, 2023 · 0 comments
Closed

Make all the 'Loading' strings consistent #52886

afercia opened this issue Jul 24, 2023 · 0 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 24, 2023

Description

In the editor, while some parts of the UI are still loading their content, some text is used to inform users content is still loading. For example, the list of pages in the Site editor:

Loading pages

These strings are inconsistent:

  • Some of the use an ellipsis at the end, some don't.
  • One string has a trailing period.
  • One string has an extraneous space.

Here's the strings in the current codebase that start with Loading:

Loading options…
Loading … (notice the space before the ellipsis)
Loading Navigation block setup options.
Loading pages
Loading patterns
Loading templates

Personally, I'd vote for always using the ellipsis, as that seems to be the most common pattern historically used in Core.
Extraneous spaces and period should be removed.
Waiting for design feedback… 🙂

Step-by-step reproduction instructions

  • Scan the codebase for translatable strings that start with Loading. A good pattern for the search is: __( 'Loading
  • See the inconsistencies in the strings.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. labels Jul 24, 2023
ducksblock added a commit to ducksblock/gutenberg that referenced this issue Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant