Only request fallback navigation menu if necessary #52775
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
getdave
reviewed
Jul 20, 2023
| __unstableMarkNextChangeAsNotPersistent(); | ||
| setRef( navigationFallbackId ); | ||
| setRef( getNavigationFallbackId() ); |
There was a problem hiding this comment.
The first time this runs the ref may end up being set to null because the selector has an async resolver.
getdave
reviewed
Jul 20, 2023
| if ( ref || hasUnsavedBlocks || ! navigationFallbackId ) { | ||
| if ( | ||
| ! navMenuResolvedButMissing || | ||
| navigationMenus.length > 0 || |
There was a problem hiding this comment.
"Fallback" is an interesting concept. It doesn't mean "create a fallback". I mean "get the most appropriate menu to use as a fallback".
This will run
- if there are no menus at all
- if there are menus but this particular nav block does not have a
ref
Prior to this we just had lots of "use the first menu" scattered all over the place so the fallback selector helps to unify this.
That said, if the selector doesn't immediately return data from state, then it will trigger a resolver which is async and thus we do need to conditionalise it.
There was a problem hiding this comment.
Hmmm... So we need to make a request for the fallback if there are no menus, or if we don't know what menu they want. So, it was decided to be better UX to show some menu over an error/no menu?
There was a problem hiding this comment.
Yes that's it. So we want to avoid a "no menus" situation.
So we
- get the most recently created Navigation Menu post (if available). If not we fall back to...
- convert a most recently created Classic Menu to a Navigation Menu and use that. If no classic menu we fall back to...
- create a Navigation Menu and use that.
That logic is all server side in a dedicated class that is called from the fallback endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The navigation fallback menu is being requested unnecessarily.
Why?
To save network requests 🐎
How?
If there are navigation menus available, we don't need a fallback (I think).
It may be better to add a
needsFallbackMenuor something touseNavigationMenuthat can handle this more easily across other places.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast