Link control: migrate tests to Playwright. Can be created by selecting text and using keyboard shortcuts #50996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
changed the title
|
Size Change: +1.32 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 13000dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5092495551
|
MaggieCabrera
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
getdave
reviewed
May 26, 2023
MaggieCabrera
force-pushed
the
migrate-show-list-view-test
branch
from
0ff31a9 to
9d3e062
Compare
kevin940726
reviewed
May 29, 2023
| expect( await editor.getEditedPostContent() ).toMatchSnapshot(); | ||
|
|
||
| // Tab back to the Submit and apply the link. | ||
| await page.getByRole( 'button', { name: 'Save' } ).click(); |
There was a problem hiding this comment.
This is failing. We should probably limit the scope under some parent locator. I found out that the link setting popover doesn't have an accessible name. When I'm testing it, I also noticed that the focus is trapped inside the popover, so maybe what it should really be is a modal/dialog instead? This can all be a follow-up though 😅.
There was a problem hiding this comment.
Good point, I could only target the parent using a class. Let's follow up by improving the popover and updating the test as necessary
|
This just needs a ✅ I believe |
kevin940726
approved these changes
May 29, 2023
|
|
||
| // Tab back to the Submit and apply the link. | ||
| await page | ||
| .locator( '.block-editor-link-control' ) |
There was a problem hiding this comment.
Nit: Let's add a temporary comment explaining why a CSS selector is needed here. Same for #51001. ❤️
There was a problem hiding this comment.
Thank you, I appreciate your reviews as always!
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…g text and using keyboard shortcuts (WordPress#50996) * initial setup * fixed utils * update snapshots, commented waitForURLFieldAutoFocus * removed old test * removed unneeded code * removed old snapshots * use locator instead of component class * remove appender function * use locators instead of tabbing around * rename button * avoid snapshots and fix locator for Save button * removed snapshots * added comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #50995
This PR migrates the test "Can be created by selecting text and using keyboard shortcuts" for the link control component to playwright
Why?
In an effort to migrate our e2e tests to use playwright, we've decided to pick up some of the tests for this component as we work on it to improve it, instead of trying to maintain the puppeteer tests.
How?
Following the guidelines for e2e tests migrations
Testing Instructions
run
npm run test:e2e:playwright -- -g "Can be created by selecting text and using keyboard shortcuts"and the test should pass