Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider modal/dialog for Link Control popover when used #51060

Open
MaggieCabrera opened this issue May 29, 2023 · 3 comments
Open

Consider modal/dialog for Link Control popover when used #51060

MaggieCabrera opened this issue May 29, 2023 · 3 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@MaggieCabrera
Copy link
Contributor

While working on the component's tests, we found that the popover doesn't have an accessible name. Also the focus is trapped inside the popover.

Should we be using a modal/dialog instead?

/cc @getdave

@MaggieCabrera MaggieCabrera changed the title Link Control: Link Control: focus issues May 29, 2023
@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels May 29, 2023
@getdave getdave changed the title Link Control: focus issues Consider modal/dialog for Link Control popover when used Jun 6, 2023
@getdave
Copy link
Contributor

getdave commented Jun 6, 2023

I actually don't know. I'd have to defer to folks with specific expertise in this area as it seems quite difficult to know what's best.

Do we have any components that fulfil the role? Surely our Popover is accessible and provides the correct role .etc?

@alexstine
Copy link
Contributor

If you implement focus trap, it is probably best to implement modal while you are at it. Screen readers on Windows cannot navigate out of modals via browse/virtual mode but they can navigate away from popovers, non-modals. I define modals as the <modal tag or role="modal". The Modal in wordpress/components should be fine.

@getdave
Copy link
Contributor

getdave commented Aug 31, 2023

Working on focus trap in #54085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants