-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port colord to PHP #49700
Port colord to PHP #49700
Conversation
Flaky tests detected in b6f7783. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4661920005
|
* @return string The SVG for the filter definition. | ||
*/ | ||
public static function get_filter_svg_from_preset( $preset ) { | ||
// TODO: This function will be refactored out in a follow-up PR where it will be deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This would be a good candidate to backport to core now. |
That's a good idea! The new code will also need the PHPUnit tests. |
What?
Part 1 in a set of duotone php refactoring to fix small issues in duotone rendering.
This part deprecates tinycolor functions and uses a private port of colord for duotone instead to match the JS.
Why?
How?
Testing Instructions
Example content for TT3 block-out, canary, and pilgrimage variations