Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix broken Lerna documentation link #48890

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Docs: Fix broken Lerna documentation link #48890

merged 1 commit into from
Mar 7, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Mar 7, 2023

What?

PR fixes the broken documentation link for Lerna's from-package command.

Testing Instructions

CI is passing.

@Mamaduka Mamaduka self-assigned this Mar 7, 2023
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Mar 7, 2023
@Mamaduka Mamaduka requested review from ntsekouras and gziolo March 7, 2023 13:37
fabiankaegy
fabiankaegy approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Flaky tests detected in 3ee3dcf.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4354710169
📝 Reported issues:

@Mamaduka Mamaduka merged commit b28d4e0 into trunk Mar 7, 2023
@Mamaduka Mamaduka deleted the fix/release-docs-broken-lerna-link branch March 7, 2023 14:28
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@ntsekouras ntsekouras Awaiting requested review from ntsekouras

@gziolo gziolo Awaiting requested review from gziolo

Assignees

@Mamaduka Mamaduka

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @fabiankaegy