Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read More: I18N: update string concatenation method in read more block #47815

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Read More: I18N: update string concatenation method in read more block #47815

merged 1 commit into from
Feb 7, 2023

Conversation

kebbet
Copy link
Contributor

@kebbet kebbet commented Feb 7, 2023 •
edited by Mamaduka
Loading

What?

Update the way a string is concaternated in the read more block
Fixes #47812

Why?

Strings should be constructed with the I18N-functions in core.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@kebbet kebbet requested a review from ajitbohra as a code owner February 7, 2023 08:47
carolinan
carolinan approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen reader text in the read more block contains the correct post title or post id.

aristath
aristath approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@aristath aristath merged commit 115177e into WordPress:trunk Feb 7, 2023
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 7, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Block] Read More Affects the Read More Block labels Feb 7, 2023
@kebbet kebbet deleted the string-concatenation-for-the-read-more-block branch February 7, 2023 09:50
ntsekouras pushed a commit that referenced this pull request Feb 7, 2023
@kebbet @ntsekouras
I18N: update string concatenation method in read more block (#47815)
50f7b5d
@ntsekouras
Copy link
Contributor

Cherry-picked this PR to the wp/6.2 branch.

@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 7, 2023
@DaisyOlsen DaisyOlsen changed the title I18N: update string concatenation method in read more block Read More: I18N: update string concatenation method in read more block Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Package] Block library /packages/block-library label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@aristath aristath aristath approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Read More Affects the Read More Block Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.

Wrong string concatenation for the read more block.
6 participants
@kebbet @ntsekouras @aristath @carolinan @Mamaduka @DaisyOlsen