Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong string concatenation for the read more block. #47812

Closed
youknowriad opened this issue Feb 7, 2023 · 5 comments · Fixed by #47815
Closed

Wrong string concatenation for the read more block. #47812

youknowriad opened this issue Feb 7, 2023 · 5 comments · Fixed by #47815
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

youknowriad commented Feb 7, 2023 •
edited
Loading

Description

Introduced in #45490

We received this feedback related to the change from the PR above https://core.trac.wordpress.org/ticket/57471#comment:27

Basically we should avoid concatenation when it comes to translated strings. We might also want to add a "since" doc block.

Let's make sure to follow-up on that and label the PR with the "backport to WP beta/RC" label to include on the next package update in core.
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts labels Feb 7, 2023
@youknowriad youknowriad mentioned this issue Feb 7, 2023
Merged
@Mamaduka Mamaduka moved this to 📥 Todo in WordPress 6.2 Editor Tasks Feb 7, 2023
@carolinan
Copy link
Contributor

I don't think the feedback link is correct? It is for the copy_dir change.

@youknowriad
Copy link
Contributor Author

yeah, sorry, it's fixed now.

@kebbet
Copy link
Contributor

kebbet commented Feb 7, 2023

A quick look in some other *.php files in wp-includes/blocks reveals that all functions in them are missing @since tags. So maybe nothing to address in this issue?

@kebbet kebbet mentioned this issue Feb 7, 2023
Merged
@kebbet
Copy link
Contributor

kebbet commented Feb 7, 2023

Created a PR to address it, might be other nicer or smarter solutions, but this is one solution to the issue.

@carolinan carolinan mentioned this issue Feb 7, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 7, 2023
@carolinan
Copy link
Contributor

😄

@carolinan carolinan removed their assignment Feb 7, 2023
@Mamaduka Mamaduka moved this from 📥 Todo to ✅ Done in WordPress 6.2 Editor Tasks Feb 7, 2023
@Mamaduka Mamaduka closed this as completed Feb 7, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.2 Editor Tasks
Status: ✅ Done
Milestone
No milestone
5 participants
@Mamaduka @youknowriad @carolinan @kebbet @priethor