Fix padding and margin visualizer styles #47139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Priority] High
|
Size Change: +15 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
I thought popovers were rendered outside the iframe, and since |
jorgefilipecosta
approved these changes
Jan 13, 2023
It seems like its related to the An alternative fix could be this - https://github.com/WordPress/gutenberg/compare/fix/padding-and-margin-visualizer-slot?expand=1. In my testing the visualizers no longer seem to work accurately after that change. Not sure why. I think it'd be best to merge this first so that the feature isn't broken. There can be a follow up to try to move the popovers outside the iframe. |
priethor
removed
the
Backport to Gutenberg RC
|
I've followed up with another PR #47483, which makes the visualizers use a slot. I'm not seeing the issues I was before, so hopefully it's fine to move forwards with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed in passing that the padding and margin visualizer styles are really broken
How?
This seems to be a result of the introduction of iframed content in the post editor. I think the styles should be in the content.scss file, but this is the first time I've seen it so I may be wrong.
Testing Instructions
Testing Instructions for Keyboard
This isn't really a keyboard friendly feature
Screenshots or screencast
Before
Kapture.2023-01-13.at.17.27.14.mp4
After
Kapture.2023-01-13.at.17.25.26.mp4