Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding and margin visualizer broken showing all black #47344

Closed
annezazu opened this issue Jan 23, 2023 · 4 comments
Closed

Padding and margin visualizer broken showing all black #47344

annezazu opened this issue Jan 23, 2023 · 4 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

The padding and margin visualizer seems to be broken with Gutenberg 15.0. cc @youknowriad since you helped implemented this feature.

Step-by-step reproduction instructions

  1. Open Appearance > Editor.
  2. Select a block with padding and margin support, like a Heading block.
  3. Open block settings and notice the black bar that shows up when changing margin/padding.

Screenshots, screen recording, code snippet

visualizer.broken.mov

Environment info

  • WP 6.1.1
  • GB 15.0
  • TT3
  • Chrome Version 108.0.5359.124
  • MacOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jan 23, 2023
@youknowriad
Copy link
Contributor

If I'm not wrong this has been fixed recently or has a PR or something. @t-hamano might know?

@t-hamano
Copy link
Contributor

I believe this problem was fixed in #47139. But this is included in Gutenberg 15.1 and has not been released yet.

@youknowriad
Copy link
Contributor

Thanks @t-hamano makes sense.

@annezazu
Copy link
Contributor Author

Amazing. Sorry for missing this one too! Tried to check current issues rather than PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowriad @annezazu @t-hamano