Ensure appropriate fallback menu title in Nav block menu selector #47073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
Size Change: +289 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2c18a4d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3904340279
|
getdave
changed the title
scruffian
reviewed
Jan 12, 2023
packages/block-library/src/navigation/edit/navigation-menu-selector.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensures all menus in the Nav block menu selector have a name.
Closes #47060
Why?
It's possible for a given menu(s) to not have a
titleproperty (i.e. one which is an empty string). In this case we currently display nothing in the dropdown (see Issue).This needs to be fixed to allow the user to switch between menus.
How?
Checks for title and if missing provides a suitable fallback with an appropriate index to distinguish between them if there are mutliple untitled menus.
Testing Instructions
Untitled menu %%index%%for each of the untitled menus.Testing Instructions for Keyboard
Screenshots or screencast