Ensure appropriate fallback menu title in Nav block menu selector (#4…

…7073) * Ensure appropriate fallback * Change the untitled name Co-authored-by: Ben Dwyer <[email protected]>
WordPress · Jan 12, 2023 · 7e52fbb · 7e52fbb · github-actions · Jan 12, 2023
1 parent 9380c25
commit 7e52fbb
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/block-library/src/navigation/edit/navigation-menu-selector.js b/packages/block-library/src/navigation/edit/navigation-menu-selector.js
@@ -68,8 +68,12 @@ function NavigationMenuSelector( {
 
 	const menuChoices = useMemo( () => {
 		return (
-			navigationMenus?.map( ( { id, title } ) => {
-				const label = decodeEntities( title.rendered );
+			navigationMenus?.map( ( { id, title }, index ) => {
+				const label =
+					decodeEntities( title.rendered ) ||
+					/* translators: %s is the index of the menu in the list of menus. */
+					sprintf( __( '(no title %s)' ), index + 1 );
+
 				if ( id === currentMenuId && ! isCreatingMenu ) {
 					setSelectorLabel(
 						/* translators: %s is the name of a navigation menu. */