Post editor: fix title margin #46698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Dec 21, 2022
| 'edit-post-visual-editor__post-title-wrapper', | ||
| { | ||
| 'is-focus-mode': isFocusMode, | ||
| } | ||
| }, | ||
| blockListLayoutClass |
There was a problem hiding this comment.
For TT3, these classes are enough to restore the padding, but some themes use block-editor-block-list__layout or is-root-container. We should just make sure we use the same classes as the root block list.
There was a problem hiding this comment.
Ideally, we also render the post title as a proper block, but that's a bit of a challenge right now.
|
Size Change: +4 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 21, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Restores margin and padding on the title in the iframed post editor. The problem is that the title wrapper should have to same classes as the root block list, so it gets the same padding. For the top margin, I passed it as an extra style to the iframe. Ideally we should be using a default body margin in the future.
Why?
How?
Testing Instructions
Open the post editor with TT3.
Testing Instructions for Keyboard
Screenshots or screencast