Post title: add block-editor-block-list__layout class #34585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.41 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
This issue this fixes looks like it's very specific (in my case I was able to reproduce on a WordPress.com site but not elsewhere). The CSS change does help, although I wasn't able to test the PR directly because of environment constraints. Curious what @fullofcaffeine thinks as I know he was able to reproduce the same Firefox issue with Twenty Twenty post titles in the editor that I was seeing. |
|
Is there an issue connected to this? I am not sure what to test for. |
|
@chad1008 @fullofcaffeine Is this still needed for .com? I think this is good to merge regardless, it's a sensible change. |
|
Hi @ellatrix, is this PR still required? If yes I guess it just needs a rebase and I can review it right after. |
|
Actually this was just recently added in #46698, so this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems to be needed for some CSS to be applied to the post title.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).