Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize the map objects properly in the Redux dev tools #46282

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Serialize the map objects properly in the Redux dev tools #46282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/data/src/redux-store/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ const trimUndefinedValues = ( array ) => {
return result;
};

// Convert Map objects to plain objects
const mapToObject = ( key, state ) => {
if ( state instanceof Map ) {
return Object.fromEntries( state );
}

return state;
};

/**
* Create a cache to track whether resolvers started running or not.
*
Expand Down Expand Up @@ -256,6 +265,9 @@ function instantiateReduxStore( key, options, registry, thunkArgs ) {
window.__REDUX_DEVTOOLS_EXTENSION__( {
name: key,
instanceId: key,
serialize: {
replacer: mapToObject,
},
} )
);
}
Expand Down