Serialize the map objects properly in the Redux dev tools #46282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +34 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
I wonder if this is something to do for There might be some optimization around that too, although it might still be necessary to create a That may be a problem with |
|
We do create Maps on each change, but it's still more performant than creating and spreading objects on each change.
I didn't see any of that in any of the refactored reducers. |
Are we already using "Set" objects in reducers, couldn't find any? |
You're right, there are a couple of cases in actions/resolvers, but not as many as I thought (should've checked beforehand). Not worth worrying about then. |
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ref: #46146 (comment)
After the recent refactoring of the block editor store to use maps instead of plain objects, the redux dev tools stopped showing the state properly. This PR transforms back the "maps" into "objects" in the Redux dev tools to show the updates properly there.
Testing Instructions