Refactor the block-editor "tree" state to use maps instead of objects #46229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +145 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
perf/refactor-tree
branch
from
5f2ae6d to
cab111a
Compare
youknowriad
force-pushed
the
refactor/tree-state
branch
from
29af52d to
cae5e46
Compare
| @@ -91,6 +91,18 @@ function flattenBlocks( blocks, transform = identity ) { | |||
| return result; | |||
| } | |||
|
|
|||
| function getFlattenedClientIds( blocks ) { | |||
There was a problem hiding this comment.
If this function is called many times, and is worth a performance improvement, I think avoiding the stack array and the array operations and simply having a recursive function navigating the inner blocks tree is more performant.
There was a problem hiding this comment.
Actually no, a recursive function is in general less performant than the stacked alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #46204 #46221 #46225 and #46146
Following a similar approach to the previous PRs, I tried to see how refactoring the parents state from plain objects to maps could impact the performance. Here are the results I got:
Before:
After: