Block Editor: Refactor the block-editor parents state to use maps instead of objects. #46225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
perf/refactor-order-state
branch
2 times, most recently
from
f192f44 to
8ad5aa0
Compare
ntsekouras
approved these changes
Dec 2, 2022
youknowriad
force-pushed
the
perf/refactor-tree
branch
from
5f2ae6d to
cab111a
Compare
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
|
I think this PR had an unintended side effect of making it impossible to select the inner blocks of a contentOnly locked pattern. Here's a sample pattern: I found this PR as the "breaking" one purely by shotgun debugging, checking out commits, and specifically the behavior broke between these two commits:
Before the topmost of those two commits, it worked like this (
After that top commit, it's now broken, like this:
|
|
Thanks for catching that, fix in #46494 |
ryanwelcher
changed the title
|
Hey @youknowriad. 👋🏻 I reviewed this PR and the related ones listed in the description while exploring typing performance in the native mobile editor. At a high-level, do you consider the effort to use |
|
Hey @dcalhoun yeah at the moment, I think this is "done" from my point of view. I do think there's more we can do in the reducer but I remember doing more of these changes in some of parts of the reducer and not measuring the perf gains like I did for the merged PRs. So yeah, no changes coming in this area from me, but let's keep an eye for potential improvements. |
|
Some time ago I created a draft PR that migrates the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #46204 #46221 and #46146
Following a similar approach to the previous PRs, I tried to see how refactoring the parents state from plain objects to maps could impact the performance. Here are the results I got:
Before:
After: