Writing flow: fix partial selection when dragging in between blocks #44230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
This is working well for me:
|
|
This is looking good actually. I think there were problems with the anchor node without this condition, but it seems fine with the focus node. |
ellatrix
changed the title
jasmussen
added
[Priority] High
jasmussen
approved these changes
Sep 16, 2022
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 6e21833 |
ockham
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the condition that skips partial selection if the focus node of the selection is the rich text wrapper. When dragging in between blocks, the focus node is the rich text wrapper.
Why?
Fixes #44153.
How?
Testing Instructions
Screenshots or screencast