Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection switches between partial and multi-select when cursor is between blocks #44153

Closed
jasmussen opened this issue Sep 14, 2022 · 1 comment · Fixed by #44230
Closed
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention

Comments

@jasmussen
Copy link
Contributor

When making a partial selection between two blocks, and the selection is made somewhat quickly, the blue selection borders do not appear. However when moving the cursor slowly and pausing in the space between blocks, the blue borders do appear:

selection

When you are making a partial selection, is-partially-selected and is-multi-selected classes are both applied to the block. However when your cursor is between two blocks, is-partially-selected is briefly removed, as shown in this GIF of the inspector and the applied classes during selection:

190150747-ade7c530-2c08-4eb8-809a-04844b7747a8

Ideally the is-partially-selected class should remain in place even when hovering between blocks, up until the point where when a non-text block is selected and the partial selection becomes a multi-selection. This would fix the flickering issue you can otherwise see when selecting multiple paragraphs.

See also: #44148.

@jasmussen jasmussen added [Priority] High Used to indicate top priority items that need quick attention Needs Dev Ready for, and needs developer efforts [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Sep 14, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 14, 2022
@jasmussen
Copy link
Contributor Author

Created #44154 as a potential fix for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
2 participants