Lodash: Refactor away from _.isPlainObject()
#42508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
mirka,
aristath,
swissspidy,
ciampo,
jorgefilipecosta,
chad1008,
andrewserong,
ntsekouras and
fabiankaegy
|
Size Change: +200 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/lodash-is-plain-object
branch
from
30b6ab9 to
9ecb68c
Compare
gziolo
reviewed
Jul 19, 2022
gziolo
reviewed
Jul 19, 2022
| @@ -36,6 +36,7 @@ module.exports = { | |||
| transform: { | |||
| '^.+\\.[jt]sx?$': '<rootDir>/test/unit/scripts/babel-transformer.js', | |||
| }, | |||
| transformIgnorePatterns: [ 'node_modules/(?!(is-plain-obj))' ], | |||
There was a problem hiding this comment.
Interesting, is Jest still having issues with ES modules?
There was a problem hiding this comment.
Yes! If we ditch that, a bunch of unit tests where this module is directly or transitively used will fail.
gziolo
approved these changes
Jul 19, 2022
tyxla
force-pushed
the
remove/lodash-is-plain-object
branch
from
9ecb68c to
0891410
Compare
tyxla
force-pushed
the
remove/lodash-is-plain-object
branch
from
0891410 to
567c4f2
Compare
|
@gziolo I've just rebased and addressed your suggestions - if I may ask you for one last look on this one - thanks 🙌 |
gziolo
reviewed
Aug 2, 2022
gziolo
reviewed
Aug 2, 2022
gziolo
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
We don't need to list dev dependencies in individual packages that use them. See https://github.com/WordPress/gutenberg/tree/trunk/packages#development-dependencies.
Everything else looks great 👍🏻
|
🚢 |
This was referenced Aug 16, 2022
|
Hey @tyxla , I think this should probably have been a major release since it causes build breakage downstream unless configuration changes are made to support transforming is-plain-obj |
|
@rjchow, it definitely created more friction than we anticipated. Apparently, the Node ecosystem is far from ready to start using ES Modules today. I would rather avoid calling it a breaking change since it doesn't have any impact on the functionality of the updated packages. Is it only Jest that has issues with this package? We should fix it with the revised patch that @tyxla opened yesterday. If this impacts more tools, then maybe we should switch to another library that still supports CommonJS like |
|
I'm happy to replace the library if need be, but from the data we have so far, it seems like only Jest has issues, and #43271 should be solving that. |
Ok, let's try that first and keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.isPlainObject()usage completely and deprecates the function.Alternative to #42471.
Part of #16938.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using the is-plain-obj package because it does exactly what we want, has type bindings, and is simple and well-contained enough.
Testing Instructions