Element: Introduce isPlainObject() utility
#42471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
adamziel,
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
andrewserong,
ntsekouras and
fabiankaegy
|
Size Change: +55 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
I don't think that |
2 tasks
|
Thanks for the feedback @gziolo! Really helpful to set the path ahead. I'm happy to create separate packages outside of the Gutenberg repo when the need comes. Going to start with As for addressing the problem of bundling multiple copies of the same package, I think we can work on it separately as part of #17025. Going to close this one and come up with an external package for this one. |
5 tasks
|
Started work on the new package in Automattic/wp-calypso#65668 - going to circle back to this one once we publish it. |
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces a new local
isPlainObject()utility to replace Lodash's version. Part of the effort to completely remove Lodash from Gutenberg.I'd like to seek some feedback on two points here:
@wordpress/elementpackage, given that it's necessary for rendering style attribute values? Any better place to place it?This is part of #16938.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're essentially duplicating how Lodash's
isPlainObject()works, in order to support objects withnullprototype. Take a look at the tests to see what values we're expecting to betrueandfalse.If we all agree on this approach, I'm planning to work on a few more PRs to remove the rest of
isPlainObject()including the custom inline versions I introduced in #41751.Testing Instructions