Lodash: Refactor away from _.reject()
#42040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
antonis,
aristath,
gziolo,
swissspidy,
geriux,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: +57 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
fluiddot
reviewed
Jul 5, 2022
Comment on lines
+107
to
+109
| ...( activeFormats?.filter( | ||
| ( { type } ) => type !== format.type | ||
| ) || [] ), |
There was a problem hiding this comment.
I checked this change in the native version and confirm it's working as expected 🎊 .
There was a problem hiding this comment.
Thanks for the confirmation @fluiddot 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
reject()is used only a few times in the entire codebase. This PR aims to remove that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Removing
_.reject()is straightforward in favor ofArray.prototype.filter().We also use the opportunity to remove a couple of stray
find()usages that are easily replacible withArray.prototype.find().Testing Instructions
npm run test-unit packages/rich-text