Mobile - Highlight text - Force format for some edge cases #37915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
…'s no text selection
geriux
force-pushed
the
rnmobile/fix/highlight-text-improvements
branch
from
bb78d35
to
d9f44f5
Compare
2 tasks
# Conflicts: # packages/react-native-editor/CHANGELOG.md
# Conflicts: # packages/react-native-editor/CHANGELOG.md
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some edge cases when applying a highlighted text color format although there are still a few limitations on the native side (Aztec) but for most cases now it should work as expected.
For cases where the caret is positioned at the end of the text, it'll apply the format manually so new entries of text will use the selected color.
For edge cases where we don't have support yet, it won't try to apply the format to avoid confusion seeing this format in the toolbar enabled but not showing in the actual test. An example of this edge case would be placing the caret in the middle of a word and toggling on the highlighted text format.
Selecting a text to apply a color format should work as expected.
On Android, changing the color with the caret positioned a the end of a word without a space in between it'll change the color of the entire word.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).