-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Global Styles: Impossible to open welcome guide if global styles are empty. #40888
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
fix/global-styles-impossible-to-open-welcome-guide-if-global-styles-are-empty
May 6, 2022
Merged
Fix: Global Styles: Impossible to open welcome guide if global styles are empty. #40888
jorgefilipecosta
merged 1 commit into
trunk
from
fix/global-styles-impossible-to-open-welcome-guide-if-global-styles-are-empty
May 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
An existing feature does not function as intended
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
May 6, 2022
jorgefilipecosta
changed the title
Fix: Global Styles are always resettable.
Fix: Global Styles: Impossible to open welcome guide if global styles are empty.
May 6, 2022
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
May 6, 2022
Size Change: -2 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed the problem while testing #40887. Code LGTM.
jorgefilipecosta
deleted the
fix/global-styles-impossible-to-open-welcome-guide-if-global-styles-are-empty
branch
May 6, 2022 17:02
I've cherry-picked this to wp/6.0 branch to be included in WordPress 6.0 RC2 later today 6ac1618 |
adamziel
pushed a commit
that referenced
this pull request
May 10, 2022
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toggle menu on the global styles sidebar now opens the welcome guide and the option to reset the styles. But it is disabled if it is not possible to reset. This makes it impossible to open the welcome guide if the global styles are empty. This PR fixes the issue.