Fix: Global Styles are always resettable. #40887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
Global Styles
|
Size Change: -15 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
I've cherry-picked this to wp/6.0 branch to be included in WordPress 6.0 RC2 later today 7a10949 |
adamziel
removed
the
Backport to WP 6.7 Beta/RC
adamziel
pushed a commit
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props to @draganescu for reporting this issue.
isGlobalStylesUserThemeJSON and version are now managed on the server, and the reset hook was not updated to take into account this fact. That caused a bug where even after a reset canReset returned true and the user could "reset" the styles again. This PR fixes the issue and updates the canReset hook.
Testing Instructions
I went to the site editor, reset the styles, and verified it was not possible to reset them again.