Button: add text transform control. #40858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
added
[Block] Buttons
carolinan
approved these changes
May 6, 2022
madhusudhand
approved these changes
May 6, 2022
aristath
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds text transform controls to the button block.
Why?
It would be useful to be able to set button block's text to be uppercase from the editor.
Also, you can already set the text transform on button blocks via theme.json, but this isn't great because the user can't disable it from the site editor.
How?
Adds a one-liner to the block.json. I checked the global styles panel and the controls don't appear there — what do I need to do to make that happen?
Testing Instructions
Kapture.2022-05-05.at.13.30.18.mp4
Screenshots or screencast
cc @WordPress/block-themers