Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curator: Add button styles #5973

Merged
merged 1 commit into from
May 6, 2022
Merged

Curator: Add button styles #5973

merged 1 commit into from
May 6, 2022

Conversation

madhusudhand
Copy link
Member

Changes proposed in this Pull Request:

Button styles for the following

Filled, Outline buttons and Comments button

Normal

image

image

Hover

image

image

Active

image

image

Focus

image

image

Search and file buttons

Normal

image

Hover

image

Active

image

Focus

image

Related issue(s):

Fixes: #5919

@madhusudhand madhusudhand added the [Theme] Vivre Automatically generated label for Vivre. label May 5, 2022
@madhusudhand madhusudhand requested a review from a team May 5, 2022 11:14
@madhusudhand madhusudhand self-assigned this May 5, 2022
@madhusudhand madhusudhand changed the title Add button styles Curator: Add button styles May 5, 2022
@madhusudhand madhusudhand added the [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. label May 5, 2022
jffng
jffng approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a pretty thorough test and matches the design as far as I can tell. Implementation looks good too.

The design suggests all the buttons be in the uppercase, but I don't think we should enforce that via CSS. I realized that option is not available in the button block settings, and I think it should be so I'll open up a PR for it.

Thanks @madhusudhand !

@jffng
Copy link
Contributor

jffng commented May 5, 2022

WordPress/gutenberg#40858

@madhusudhand madhusudhand merged commit a59dc7c into trunk May 6, 2022
@madhusudhand madhusudhand deleted the cult-buttons branch May 6, 2022 06:19
@beafialho
Copy link
Collaborator

The design suggests all the buttons be in the uppercase, but I don't think we should enforce that via CSS. I realized that option is not available in the button block settings, and I think it should be so I'll open up a PR for it.

Thanks, that option should be available IMO

Regarding the button states, I gave it a look and will open up an issue about them. There are some changes I'd like to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jffng jffng jffng approved these changes

Assignees

@madhusudhand madhusudhand

Labels
[Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. [Theme] Vivre Automatically generated label for Vivre.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Curator: Styles: Buttons
3 participants
@madhusudhand @jffng @beafialho