Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate package-lock.json using Node.js 8.9.3 & npm 5.6.0 #4075

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Dec 19, 2017

Description

Follow up to #4073

This PR regenerates the package-lock.json via npm install using Node.js 8.9.3 and npm 5.6.0

How Has This Been Tested?

Tested using npm test

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ntwb ntwb added the [Type] Build Tooling Issues or PRs related to build tooling label Dec 19, 2017
@ntwb ntwb requested a review from gziolo December 19, 2017 08:20
@ntwb
Copy link
Member Author

ntwb commented Dec 19, 2017

Looking at this PR what I notice is:

• Various Jest modules have been reordered, expect, jest-mock, jest-leak-detector, jest-mock etc but everything looks good to me in this regard.

• Lots of module hashes switching from sha1's to sha512's, I'm not sure if this is a recent change to, or a recent release of npm to now preference sha512's or not.

• Quite a few packages have minor semantic version bump, so that's probably a good thing to get a few packages updated that have had minor bugs fixed and had a new minor release released.

• The diff stats are +2,030 −2,124

@gziolo
Copy link
Member

gziolo commented Dec 19, 2017

sha1 vs sha512 is a well-known issue. It would be great to see it finally fixed, but it might just the fact that they are added using a single machine :)

We have now e2e tests which give a better confidence about such changes. Speaking myself, I'm fine with merging this one.

@gziolo
Copy link
Member

gziolo commented Dec 19, 2017

Have you checked if it has impact on the bundles size for Gutenberg build files? I guess it shouldn't have, but better to double check.

@ntwb
Copy link
Member Author

ntwb commented Dec 19, 2017

Testing: npm run package-plugin

This branch: gutenberg.zip = 1,392,157 bytes
Current master branch: gutenberg.zip = 1,392,318 bytes

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in then 👍

@ntwb ntwb merged commit e133c87 into master Dec 19, 2017
@ntwb ntwb deleted the update/package-lock branch December 19, 2017 08:55
@ntwb ntwb mentioned this pull request Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants