Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jest v22.0.1 #4073

Merged
merged 4 commits into from
Dec 19, 2017
Merged

Update to Jest v22.0.1 #4073

merged 4 commits into from
Dec 19, 2017

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Dec 19, 2017

Description

• Upgrades Jest to v22.0.1 https://facebook.github.io/jest/blog/2017/12/18/jest-22.html

• Commit fcf70aa updates a single Jest snapshot per Jest v22 Mock function improvements #

How Has This Been Tested?

Ran npm test

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ntwb ntwb added the [Type] Build Tooling Issues or PRs related to build tooling label Dec 19, 2017
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onClick={[MockFunction]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirreal You might like it, it is possible as of Jest 22.x to provide your own name to the mock, too. See: https://facebook.github.io/jest/blog/2017/12/18/jest-22.html#mock-function-improvements.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast 💯

Diff for package-lock.json seems a bit big, but it looks reasonable.

@gziolo gziolo merged commit d8db53a into master Dec 19, 2017
@gziolo gziolo deleted the update/jest branch December 19, 2017 07:42
@ntwb
Copy link
Member Author

ntwb commented Dec 19, 2017

Diff for package-lock.json seems a bit big, but it looks reasonable.

@gziolo It looked reasonable to me, I'm creating a new PR to recreate the package-lock.json to see how it looks with the latest Node.js and npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants