-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unwanted default false
in ListView branch component
#39719
Merged
getdave
merged 1 commit into
trunk
from
fix/remove-unwanted-default-in-list-view-branch
Mar 25, 2022
Merged
Remove unwanted default false
in ListView branch component
#39719
getdave
merged 1 commit into
trunk
from
fix/remove-unwanted-default-in-list-view-branch
Mar 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
labels
Mar 24, 2022
Size Change: -3 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
fix/remove-unwanted-default-in-list-view-branch
branch
from
March 25, 2022 09:16
b4d91e0
to
9c163e4
Compare
scruffian
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
true
default in List View branch component. This is unwanted as the parent defaults tofalse
and thus it will already have a default.Why?
Looks like I missed this default when I merged #39611
How?
Removes the default value allowing it to use the parent's default from:
gutenberg/packages/block-editor/src/components/list-view/index.js
Line 75 in a92b73c
...which is in turn passed down to into the branch component in:
gutenberg/packages/block-editor/src/components/list-view/index.js
Line 228 in a92b73c
Testing Instructions
Screenshots or screencast