Collapse list view by default in all editors #39611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] List View
getdave
requested review from
jasmussen,
scruffian,
Mamaduka,
paaljoachim and
alexstine
|
Size Change: -3 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 21, 2022
priethor
approved these changes
Mar 21, 2022
Mamaduka
approved these changes
Mar 21, 2022
|
Thanks for all the reviews. Given the scope of the change I'll leave this open for a little while longer just in case. I'll make sure @draganescu (who is handling the release) is aware of the need to reflect this change in the Changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR defaults the List View to have all branches/nodes collapsed by default across all Editors by altering the default expanded state on the underlying
<ListView>component.Why?
This is a follow up to #39573 where we collapse all nodes on the Site Editor only. Many folk suggested this would be good feature to have on all ListView instances across all editors.
How?
The PR marks the
expandNestedprop of the underlying<ListView>component to befalseby default.This means all nodes are collapsed but they can be expanded manually or by clicking on a given block in the canvas.
Testing Instructions
Screenshots or screencast
Screen.Capture.on.2022-03-21.at.12-07-33.mov