Collapse list view by default in Site Editor #39573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Feature] List View
|
Size Change: +7 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
Nice one! GIF showing collapsed by default list view with nodes opening when selecting them in the canvas: Works great! Especially since the nodes are expanded as soon as you click anything in the canvas. |
scruffian
approved these changes
Mar 18, 2022
|
Thanks for feedback. I'll leave this open over the weekend to allow for further feedback. |
|
This is a very good idea Dave! |
|
This looks great 👍 |
|
Note this is only in the Site Editor. We could expand to others editors by changing the prop to default to |
alexstine
approved these changes
Mar 18, 2022
priethor
approved these changes
Mar 20, 2022
|
Ok thanks folks. That's enough 👍 for us to merge this one. I will follow up with a wider proposal shortly in order that this applies to all editors. |
|
Follow up is here #39611 |
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR sets nodes within the List View to be collapsed by default.
Why?
In #34759 a few folks said the list view could be overwhelming. This also has accessibility concerns.
Given that the Site Editor is the most likely to have heavily nested block structures it makes sense to experiment with making all nodes collapsed by default here first.
This should make the initial list view experience a lot less overwhelming.
How?
It toggles to
falsethe newexpandNestedprop of<ListView>which forces all nodes to default tocollapsedstate.Testing Instructions
Screenshots or screencast