Icons: Update lock and unlock icons to be smaller. #39252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.82 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
Here's an example of updated icons from Block Locking UI.
|
|
Hmm. The icons look a teensy bit small here, and also a bit smaller than the icon example here. I'll update these once more! |
9 tasks
|
Alright, I've updated the icons to be slightly bigger to match what was suggested on the other thread:
|
|
I'm not sure if it's the dimensions of each element in relation to one another, but as it gets larger it starts to resemble a bag. Probably not a big deal, mostly just a curious observation. If we wanted to address that, I think a keyhole helps:
But totally understand if we want to keep it minimal. We can always address this if/when we add a bag icon in the future. |
|
The hole always felt "decorative" to me, but I agree it's a nice option to have. We could potentially start here, for the locking UI, and get a feel for it, and I'd be happy to follow up? |
jameskoster
approved these changes
Mar 10, 2022
|
Cool, I'll land and I'll be on the lookout for followups! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on conversation in #29864 (comment), the existing lock icons are a bit chunky:
This PR updates them with some unpublished concepts that are less chunky:
Figma has been updated.
Testing Instructions
Test in storybook and observe the "after" icons there.
Checklist:
*.native.jsfiles for terms that need renaming or removal).