-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try an outlined lock icon for block locking #39916
Comments
@jasmussen made a good point that the icon should probably have some heft to it – it is a lock after all! :) Another option we explored before was adding a keyhole: Perhaps this is a good compromise? It adds a little character to make the icon feel more aligned with others in the set, whilst maintaining most of the weight. |
Another item to consider: using the full lock when all options are checked vs using an outline to represent a passive state without any locking in place. |
Hi, |
Hi folks, this issue came up in today's Editor Bug Scrub. Just wanted to check in and see what the next steps might be. I personally like the outlined version, but that's just me 😅 |
I think Joen's suggestion is a good one – outlined version in the ellipsis menu, filled version when indicated a block is locked (IE in List View and the block toolbar). It's a low-priority item though. |
What problem does this address?
In excitedly testing block locking with GB 12.9, I noticed that the icon itself is quite heavy for lack of a better term and my eye was immediately drawn to it every time. It was to the point that I worry we might be overemphasizing the feature in a way that doesn't reflect the usage it likely should have:
What is your proposed solution?
In chatting with @jameskoster for a confidence check on this, he shared the possibility of using an outline:
Here's what this would loosely look like:
I think it strikes the right balance and matches the other icons/visuals in the menu.
The text was updated successfully, but these errors were encountered: