Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try an outlined lock icon for block locking #39916

Closed
annezazu opened this issue Mar 30, 2022 · 6 comments · Fixed by #45645
Closed

Try an outlined lock icon for block locking #39916

annezazu opened this issue Mar 30, 2022 · 6 comments · Fixed by #45645
Assignees
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

In excitedly testing block locking with GB 12.9, I noticed that the icon itself is quite heavy for lack of a better term and my eye was immediately drawn to it every time. It was to the point that I worry we might be overemphasizing the feature in a way that doesn't reflect the usage it likely should have:

Screen Shot 2022-03-30 at 10 44 15 AM

What is your proposed solution?

In chatting with @jameskoster for a confidence check on this, he shared the possibility of using an outline:

Screenshot 2022-03-30 at 19 04 04

Here's what this would loosely look like:

Screen Shot 2022-03-30 at 1 29 46 PM

I think it strikes the right balance and matches the other icons/visuals in the menu.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. [Feature] Block Locking The API allowing for the ability to lock/unlock blocks labels Mar 30, 2022
@annezazu annezazu changed the title Try a lighter icon for block locking Try an outlined lock icon for block locking Mar 30, 2022
@jameskoster
Copy link
Contributor

@jasmussen made a good point that the icon should probably have some heft to it – it is a lock after all! :)

Another option we explored before was adding a keyhole:

Screenshot 2022-03-31 at 09 40 59

Perhaps this is a good compromise? It adds a little character to make the icon feel more aligned with others in the set, whilst maintaining most of the weight.

@annezazu
Copy link
Contributor Author

annezazu commented Apr 5, 2022

Another item to consider: using the full lock when all options are checked vs using an outline to represent a passive state without any locking in place.

@jasmussen
Copy link
Contributor

Another item to consider: using the full lock when all options are checked vs using an outline to represent a passive state without any locking in place.

A third option 😅 : show the outlined option in the ellipsis menu for when the action is passive, and show the heavy duty lock when a block is locked. The bespoke lock/unlock icons still make sense to me.

In any case, here's a new outlined icon for implementation:
Screenshot 2022-04-06 at 09 02 17

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" style="enable-background:new 0 0 24 24" xml:space="preserve"><path d="M17 10h-1.2V7c0-2.1-1.7-3.8-3.8-3.8-2.1 0-3.8 1.7-3.8 3.8v3H7c-.6 0-1 .4-1 1v8c0 .6.4 1 1 1h10c.6 0 1-.4 1-1v-8c0-.6-.4-1-1-1zM9.8 7c0-1.2 1-2.2 2.2-2.2 1.2 0 2.2 1 2.2 2.2v3H9.8V7zm6.7 11.5h-9v-7h9v7z" style="fill:#1e1e1e"/></svg>

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Oct 4, 2022
@ndiego ndiego removed the Needs Testing Needs further testing to be confirmed. label Oct 18, 2022
@ndiego
Copy link
Member

ndiego commented Oct 18, 2022

Hi folks, this issue came up in today's Editor Bug Scrub. Just wanted to check in and see what the next steps might be. I personally like the outlined version, but that's just me 😅

@jameskoster
Copy link
Contributor

I think Joen's suggestion is a good one – outlined version in the ellipsis menu, filled version when indicated a block is locked (IE in List View and the block toolbar). It's a low-priority item though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants