Simplify site icon animation on hover. #38783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +62 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
Thank you, Joen. I personally like this animation, and making it smoother will be a good improvement. As @gwwar pointed out in my PR, you'll also need to update animation for Site Editor: cc @paaljoachim. |
|
Thanks for looking, and for the reminder! The code drift of having no shared components here is pretty bad 🙈 — but I think I fixed it. Another look? |
Mamaduka
approved these changes
Feb 14, 2022
|
This is a lot better! Much smoother and just a little more subtile. Before: . After (testing this PR): |
mtias
approved these changes
Feb 14, 2022
|
With three approvals and a green button, and since it's not a ton of code, it's tempting to merge this one. I'll let it sit for tomorrow :) |
|
Cool, I'll land this one but I'm always happy to follow up! |
cbravobernal
added
General Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38575. Alternative to #38702.
This PR smooths out the animation that is added to the site icon when present. The animation helps signify the importance of the element:
When no icon is applied, the existing hover style remains:
When you toggle "reduce motion" in your browser or operating system, no animation is shown.
Testing Instructions
Add a site icon if you have none already. For example insert the site logo block, add and publish and image, then reload the page. Hover the top left button.
Checklist:
*.native.jsfiles for terms that need renaming or removal).