Remove site icon animation #38702
Closed
Remove site icon animation #38702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -62 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
Thanks @Mamaduka this tests well for the post editor, but looks like we missed the site editor component. Codewise the approach looks good. 👍 There appears to be quite a long discussion in the issue, so other reviewers should be mindful what folks agree on before landing this one. |
8 tasks
|
Closing this PR. The original issue got resolved by improving animations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes animation for Site icon from Fullscreen mode close button.
Resolves #38575
Testing Instructions
Use as site iconfrom block settings.Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).