Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs regression. #38235

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Fix docs regression. #38235

merged 1 commit into from
Jan 26, 2022

Conversation

jasmussen
Copy link
Contributor

Description

Followup to #37483, which I believe caused a regression. Sorry about that, happy to revert the original if that is preferred.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers [Type] Regression Related to a regression in the latest release labels Jan 26, 2022
@jasmussen jasmussen self-assigned this Jan 26, 2022
@jasmussen jasmussen mentioned this pull request Jan 26, 2022
Merged
7 tasks
@jasmussen
Copy link
Contributor Author

jasmussen commented Jan 26, 2022 •
edited
Loading

I guess this one might need to be merged despite the failing test? Edit: or perhaps the failing test will pass now.

@youknowriad
Copy link
Contributor

I think the failing test should pass here.

@jasmussen jasmussen mentioned this pull request Jan 26, 2022
Merged
7 tasks
@jasmussen jasmussen merged commit 60bff62 into trunk Jan 26, 2022
@jasmussen jasmussen deleted the fix/docs-paragraph branch January 26, 2022 11:26
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@aristath aristath Awaiting requested review from aristath

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mkaz mkaz Awaiting requested review from mkaz

Assignees

@jasmussen jasmussen

Labels
[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Gutenberg 12.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jasmussen @youknowriad