Paragraph: Try to avoid a trailing word in the description. #37483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Copy
jasmussen
requested review from
ajitbohra,
ellatrix,
mkaz,
nerrad and
ntwb
as code owners
|
Size Change: +5 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
mkaz
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Adding "basic" looks and sounds good. I might switch "narrative" to "writing" as it is more straight-forward, narrative is a twinge pretentious.
Start with the basic building block of all writing.
I'll approve as is, I don't feel that strongly either one you choose.
|
I agree, for me as a non-native English speaker, narrative feels strange here. |
aristath
approved these changes
Dec 20, 2021
|
Thank you all for the reviews and thoughts. We're obviously past the string freeze so this was always going to be a 6.0 thing, and it is, as it says on the tin, a super detail. In that vein, I'm going to let it sit over the winter break here and we can come back to it, see if we need to massage the verbiage or land as is! Have a great AFK if you have any, and thanks again. |
|
I'll land this one. It's tiny, and I'm super happy to follow up on it! |
|
This PR broke some tests on trunk, I think there's some docs that need to be regenerated. |
|
My apologies. I think #38235 fixes it, but I'd be happy to revert this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File this under really small details that still feel important: the description of the Paragraph block wraps on to two lines, but with only one word, "narrative":
There are a few typographic terms for when that happens, but the gist of it is that it looks slightly unbalanced, and that it would be better if there was either less text so it stuck to one line, or there was more text so it looked more balanced on two lines.
The PR changes the phrase to this:
Start with the basic building block of all narrative.The addition of the word "basic" allows it to better work on two lines. I also tried another option:
Start with the building block of all good narrative.That one doesn't feel right though, not as neutral.
I would love advice if you have better suggestions for balancing out this phrase!
Checklist:
*.native.jsfiles for terms that need renaming or removal).