Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for HTML in get_the_title #38145

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Allow for HTML in get_the_title #38145

merged 1 commit into from
Jan 24, 2022

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 21, 2022

Description

Fixes potential regression introduced in #37866 (comment) whereby get_the_title is escaped when in actual fact it's allowed to contain HTML.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Type] Regression Related to a regression in the latest release [Block] Latest Posts Affects the Latest Posts Block labels Jan 21, 2022
@getdave getdave requested a review from ajitbohra as a code owner January 21, 2022 17:52
@getdave getdave self-assigned this Jan 21, 2022
@getdave getdave mentioned this pull request Jan 21, 2022
Merged
8 tasks
@TimothyBJacobs
Copy link
Member

This looks great to me, thanks @getdave!

@aristath aristath merged commit f056c08 into trunk Jan 24, 2022
@aristath aristath deleted the fix/latest-posts-allow-title-to-contain-html branch January 24, 2022 06:54
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 24, 2022
@getdave getdave mentioned this pull request Feb 7, 2022
Closed
17 tasks
@bph
Copy link
Contributor

bph commented Feb 9, 2022 •
edited
Loading

@Mamaduka Can this be added to the WordPress 5.9.x project? It should make it into 5.9.1. I don't see that I have the proper privileges

Forum post for reference

@Mamaduka
Copy link
Member

Mamaduka commented Feb 9, 2022

@getdave, do you remember if #37866 was cherry-picked for 5.9? I don't see a label on it.

@getdave
Copy link
Contributor Author

getdave commented Feb 9, 2022

I don't believe it was. I started that entire endeavour post-5.9. But it's important to know. How can we check?

@bph
Copy link
Contributor

bph commented Feb 9, 2022 •
edited
Loading

Sorry for all the confusions. It was all about different HTML in title issue.
I don't think @Mamaduka there isn't anything to port back to 5.9. Both prs #38145 and #37866 were just merged for 12.5 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@Mamaduka Mamaduka Mamaduka approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@getdave getdave

Labels
[Block] Latest Posts Affects the Latest Posts Block [Type] Code Quality Issues or PRs that relate to code quality [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Gutenberg 12.5
Development

Successfully merging this pull request may close these issues.
5 participants
@getdave @TimothyBJacobs @bph @Mamaduka @aristath