Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late escape Latest Posts block #37866

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 11, 2022

Description

This is not a security problem. This PR simply moves escaping of all PHP output to be as "late" as possible. This means we avoid escaping variables until they are output in the HTML markup.

This is a WP Core best practice.

How has this been tested?

  • add Latest Posts block
  • check functionality is "as was"
  • check all tests pass.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Block] Latest Posts Affects the Latest Posts Block [Type] Security Related to security concerns or efforts labels Jan 11, 2022
@getdave getdave requested a review from ajitbohra as a code owner January 11, 2022 11:31
@getdave getdave self-assigned this Jan 11, 2022
@getdave getdave requested a review from ocean90 January 12, 2022 12:27
@getdave

This comment has been minimized.

@getdave
Copy link
Contributor Author

getdave commented Jan 13, 2022

Ok this is RfR.

@getdave getdave merged commit 3a4fe34 into trunk Jan 14, 2022
@getdave getdave deleted the try/late-escape-latest-posts-block branch January 14, 2022 10:35
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 14, 2022
@TimothyBJacobs
Copy link
Member

It's valid for get_the_title to contain HTML which this looks to prevent.

@getdave getdave mentioned this pull request Jan 21, 2022
8 tasks
@getdave
Copy link
Contributor Author

getdave commented Jan 21, 2022

It's valid for get_the_title to contain HTML which this looks to prevent.

@TimothyBJacobs Fix for review #38145

@getdave getdave mentioned this pull request Feb 7, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Posts Affects the Latest Posts Block [Type] Code Quality Issues or PRs that relate to code quality [Type] Security Related to security concerns or efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants